Skip to content

Upgrade go 1.15 for smaller binary #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v2
with:
go-version: 1.14 # test only the latest go version to speed up CI
go-version: 1.15 # test only the latest go version to speed up CI
- name: Run tests
run: make.exe test
continue-on-error: true
Expand All @@ -38,7 +38,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v2
with:
go-version: 1.14 # test only the latest go version to speed up CI
go-version: 1.15 # test only the latest go version to speed up CI
- name: Run tests
run: make test
continue-on-error: true
Expand All @@ -50,6 +50,7 @@ jobs:
golang:
- 1.13
- 1.14
- 1.15
steps:
- uses: actions/checkout@v2
- name: Install Go
Expand Down Expand Up @@ -77,6 +78,6 @@ jobs:
- name: Install Go
uses: actions/setup-go@v2
with:
go-version: 1.14
go-version: 1.15
- name: Check generated files are up to date
run: make fast_check_generated
2 changes: 1 addition & 1 deletion .github/workflows/tag.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v2
with:
go-version: 1.14
go-version: 1.15
- name: Unshallow
run: git fetch --prune --unshallow
- name: Login do docker.io
Expand Down
2 changes: 1 addition & 1 deletion build/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.14
FROM golang:1.15

# don't place it into $GOPATH/bin because Drone mounts $GOPATH as volume
COPY golangci-lint /usr/bin/
Expand Down
2 changes: 1 addition & 1 deletion build/Dockerfile.alpine
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.14-alpine
FROM golang:1.15-alpine

# gcc is required to support cgo;
# git and mercurial are needed most times for go get`, etc.
Expand Down
2 changes: 1 addition & 1 deletion test/enabled_linters_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ func TestEnabledLinters(t *testing.T) {
t.Run(c.name, func(t *testing.T) {
t.Parallel()

runArgs := []string{"-v"}
runArgs := []string{"--verbose"}
if !c.noImplicitFast {
runArgs = append(runArgs, "--fast")
}
Expand Down
6 changes: 3 additions & 3 deletions test/testdata/nolintlint_unused.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ package testdata
import "fmt"

func Foo() {
fmt.Println("unused") //nolint // ERROR "directive `//nolint .*` is unused"
fmt.Println("unused,specific") //nolint:varcheck // ERROR "directive `//nolint:varcheck .*` is unused for linter varcheck"
fmt.Println("not run") //nolint:unparam // unparam is not run so this is ok
fmt.Println("unused") // nolint // ERROR "directive `//nolint .*` is unused"
fmt.Println("unused,specific") // nolint:varcheck // ERROR "directive `//nolint:varcheck .*` is unused for linter varcheck"
fmt.Println("not run") // nolint:unparam // unparam is not run so this is ok
}