Dockerfile.alpine: add Git & Mercurial #922
Conversation
|
|
| # required to support cgo | ||
| RUN apk --no-cache add gcc musl-dev | ||
| # needed most times for `go get`, etc. See https://github.com/docker-library/golang/issues/80 | ||
| RUN apk add --no-cache git mercurial |
There was a problem hiding this comment.
why did you remove gcc and musl-dev?
There was a problem hiding this comment.
@jirfag The golang:alpine images already have them installed. See e.g. https://github.com/docker-library/golang/blob/7b69aab8c4a9117743168ca8b19b314c0307e415/1.13/alpine3.11/Dockerfile#L16-L17
(noted it also in the commit message, though)
There was a problem hiding this comment.
gcc and musl-dev are only used for building Go, and they are removed from the golang:alpine image at https://github.com/docker-library/golang/blob/7b69aab8c4a9117743168ca8b19b314c0307e415/1.13/alpine3.11/Dockerfile#L55
Actually, running gcc fails with the golang:alpine image.
$ docker run golang:1.13-alpine gcc
docker: Error response from daemon: OCI runtime create failed: container_linux.go:346: starting container process caused "exec: \"gcc\": executable file not found in $PATH": unknown.
ERRO[0000] error waiting for container: context canceled
$ docker run golang:1.13-alpine bash
docker: Error response from daemon: OCI runtime create failed: container_linux.go:346: starting container process caused "exec: \"bash\": executable file not found in $PATH": unknown.
ERRO[0000] error waiting for container: context canceled
There was a problem hiding this comment.
@shogo82148 Thanks for the clarification.
@jirfag I've undone this commit. Sorry about my mistake.
Fixes partly #897