Skip to content

Avoid casting the result of fetchLocation #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tomoyamachi merged 1 commit into from
Jul 23, 2022
Merged

Avoid casting the result of fetchLocation #192

tomoyamachi merged 1 commit into from
Jul 23, 2022

Conversation

@massongit
Copy link
Contributor

@massongit massongit commented Jul 18, 2022

https://github.com/goodwithtech/dockle/runs/7367330171?check_suite_focus=true

Error: pkg/utils/fetch.go:55:84: cannot convert body (type *string) to type string

A return value of fetchLocation is *string. Therefore, I avoid casting it as a string.

@tomoyamachi tomoyamachi merged commit da1a15c into goodwithtech:master Jul 23, 2022
@massongit massongit deleted the fix_cast branch July 23, 2022 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@massongit @tomoyamachi