Fix WASM demo app to use mj_loadXML instead of deprecated loadFromXML #2988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
amirt01
force-pushed
the
fix-wasm-demo-loadxml
branch
from
09d7494 to
3b6091a
Compare
The demo app was using the old loadFromXML API which was renamed to mj_loadXML in commit 49394d5 (Nov 19, 2025) as part of a broader effort to align WASM bindings with native C API naming conventions. This change updates the demo to use the current API, fixing the error: 'TypeError: mujoco.MjModel.loadFromXML is not a function' Fixes google-deepmind#2960
amirt01
force-pushed
the
fix-wasm-demo-loadxml
branch
from
3b6091a to
af00451
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The demo app was using the old loadFromXML API which was renamed to mj_loadXML in commit 49394d5 (Nov 19, 2025) as part of a broader effort to align WASM bindings with native C API naming conventions.
This change updates the demo to use the current API, fixing the error:
TypeError: mujoco.MjModel.loadFromXML is not a functionFixes #2960