Skip to content

Header Redesign Code Review comment fixes #20924

@jacob314

Description

@jacob314

The new header looks bad in the default mac terminal due to that terminal's extra line spacing.

Proposed mac terminal rendering (more symetric)

Image

Fix issue where the username when signing in with google is missing due to useEffect that never runs because only saved the first frame rendered. To repro this is fixed, auth with google and verify you can see your username on startup.

Metadata

Metadata

Assignees

Labels

area/coreIssues related to User Interface, OS Support, Core Functionalityworkstream-rollupLabel used to tag epics and features that are associated with one of the three primary workstreams🔒 maintainer only⛔ Do not contribute. Internal roadmap item.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions