-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Header Redesign Code Review comment fixes #20924
Copy link
Copy link
Closed
Labels
area/coreIssues related to User Interface, OS Support, Core FunctionalityIssues related to User Interface, OS Support, Core Functionalityworkstream-rollupLabel used to tag epics and features that are associated with one of the three primary workstreamsLabel used to tag epics and features that are associated with one of the three primary workstreams🔒 maintainer only⛔ Do not contribute. Internal roadmap item.⛔ Do not contribute. Internal roadmap item.
Description
The new header looks bad in the default mac terminal due to that terminal's extra line spacing.
Proposed mac terminal rendering (more symetric)
Fix issue where the username when signing in with google is missing due to useEffect that never runs because only saved the first frame rendered. To repro this is fixed, auth with google and verify you can see your username on startup.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area/coreIssues related to User Interface, OS Support, Core FunctionalityIssues related to User Interface, OS Support, Core Functionalityworkstream-rollupLabel used to tag epics and features that are associated with one of the three primary workstreamsLabel used to tag epics and features that are associated with one of the three primary workstreams🔒 maintainer only⛔ Do not contribute. Internal roadmap item.⛔ Do not contribute. Internal roadmap item.