Conversation
Summary of ChangesHello @jkcinouye, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the Plan Mode documentation by refining its language, reorganizing its structure, and removing unnecessary elements. The changes aim to make the documentation more accessible and easier to navigate, ensuring users can quickly grasp how to enable, use, and customize Plan Mode within the Gemini CLI. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This PR updates the documentation for Plan Mode, improving readability and structure. The changes use active language, reorganize headings, and remove the table of contents, which aligns with the goal of conforming to the style guide. I've retained the original comment regarding the removal of a critical note about the enter_plan_mode tool's incompatibility with YOLO mode from plan-mode.md. This information is still present in the tool's own documentation (planning.md) and is important for users to understand the feature's limitations. The recommendation to re-add this note is crucial to prevent user confusion and maintain consistency across the documentation.
|
Size Change: -2 B (0%) Total Size: 25.9 MB ℹ️ View Unchanged
|
g-samroberts
left a comment
There was a problem hiding this comment.
Just some items that concern me, not necessarily that we need to change it or anything.
Btw we might want to update our docs_writer skill with some of the common edits, like using "lets you" instead of "allows you" and "for example" instead of "e.g.".
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Jerop Kipruto <jerop@google.com>
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for Plan Mode to improve clarity, adopt a more active voice, and align with the style guide. The changes are generally positive, making the documentation more scannable and user-friendly. I've identified one area where a valid configuration method was removed, making the documentation incomplete. My specific feedback is in the review comment.
Note: Security Review has been skipped due to the limited scope of the PR.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Jerop Kipruto <jerop@google.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Jerop Kipruto <jerop@google.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Jerop Kipruto <jerop@google.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Jerop Kipruto <jerop@google.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Jerop Kipruto <jerop@google.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Jerop Kipruto <jerop@google.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Jerop Kipruto <jerop@google.com>
Summary
This PR updates our plan mode documentation to conform to our existing style guide.
Details
This PR:
Related Issues
Fixes #19679.
How to Validate
This is a docs-only change. Validate that there are no unintended changes or errors.
Pre-Merge Checklist