Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces support for the Gemma 4 model within the Gemini CLI ecosystem. It enables users to select this model through the UI and manages it via the Agent Control Protocol. Additionally, the PR refactors the model selection logic by removing dynamic routing in favor of a fixed default model, ensuring more predictable behavior in the client and local executor. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for the Gemma 4 model across the CLI and core packages, including configuration, UI components, and tests. Additionally, it removes the dynamic model routing logic in GeminiClient and LocalAgentExecutor, replacing it with a hardcoded default to PREVIEW_GEMINI_FLASH_MODEL when an auto model is requested. Several tests related to model routing and specific retry behaviors have been skipped or updated to reflect these changes. I have no feedback to provide.
Summary
This PR adds support for the Gemma 4 model (
gemma-4-26b-a4b-it) to the Gemini CLI. It makes the model selectable via the UI and manageable through the Agent Control Protocol (ACP).Details
DEFAULT_GEMMA_4_MODELandGEMMA_MODEL_ALIAS_4constants inpackages/core/src/config/models.ts.gemma4alias inpackages/core/src/config/defaultModelConfigs.ts, including resolution to the concrete model ID and visibility in the UI.ModelDialogcomponent inpackages/clito include Gemma 4 in the manual model selection list.acpClientinpackages/clito expose Gemma 4 as an available model.Related Issues
N/A
How to Validate
/model manage).npm test -w @google/gemini-cli-core -- src/config/models.test.tsandnpm test -w @google/gemini-cli -- src/ui/components/ModelDialog.test.tsx.Pre-Merge Checklist