Update README.md headers settable field casing#312
Merged
Conversation
Signed-off-by: Robert van Hoesel <robertvanhoesel@gmail.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Merged
sethvargo
pushed a commit
that referenced
this pull request
Mar 30, 2023
## What's Changed * Clean up unit and integration tests, remove labeler by @sethvargo in #305 * Update CI and deps by @sethvargo in #306 * Drop unused configPath field by @sethvargo in #307 * Update README.md headers settable field casing by @robertvanhoesel in #312 * chore: update dependencies (automated) by @verbanicm in #315 * Print warnings when a gcloudignore is not found by @sethvargo in #313 * Switch to pull non-secret values from env by @sethvargo in #316 * Update deps by @sethvargo in #318 ## New Contributors * @robertvanhoesel made their first contribution in #312 **Full Changelog**: v1.0.0...7a972d4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is a bit of a gotcha that the
headerssettable fields are the lowercase counterparts to their Header. The docs incorrectly mention the case sensitive varitions, which when followed causes an error:For future users and clarity, I think it is best to update the documentation to use the fully lowercase versions.