Skip to content

Conversation

@gitrey
Copy link

@gitrey gitrey commented Apr 18, 2025

agent-demo was created with agent-starter-pack create agent-demo and make install && make playground link.

Changes:

  • Added check for __init__.py file during agents list creation, endpoint /list-apps

List of folders for new agent:

image

Current list of agents when running adk web

image

List with the fix:

image

@hangfei hangfei requested a review from wyf7107 May 3, 2025 14:58
@hangfei
Copy link
Collaborator

hangfei commented May 3, 2025

@gitrey Could you fix the github CI/CD failures?

@wyf7107 could you help review?

Copy link
Collaborator

@wyf7107 wyf7107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good thanks for the contribution!

@wyf7107
Copy link
Collaborator

wyf7107 commented May 30, 2025

Could you please fix the commit message? (follow convention commit format)

@hangfei hangfei added the ready to pull [Status] This PR is ready to be importing back to Google label May 30, 2025
@hangfei
Copy link
Collaborator

hangfei commented May 30, 2025

init.py is no longer required. Closing this issue. Thanks for your contribution though.

@hangfei hangfei closed this May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to pull [Status] This PR is ready to be importing back to Google

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants