Build //:benchmark as a static library only.

[junyer]

If someone or something ever needs the dynamic library as a Bazel build
artifact, we can figure that out for them then, but right now, there is
no strong reason to be wrangling various export.h-controlling macros.

Fixes #1372.

[dmah42]

i thought that the python bindings required a dynamic library (so we should keep the bindings rule the same)... am i wrong?

[junyer]

This change doesn't affect how py_extension() builds the .so/.dll for the Python extension. Note that it was already linking the static library (linkstatic = True) and the previous issue was that it wasn't defining BENCHMARK_STATIC_DEFINE. With this change, it will continue to link the static library, but the macro will now be defined by //:benchmark (i.e. centrally) and propagated to dependent rules such as this.

[dmah42]

thanks!

[dmah42]

https://github.com/google/benchmark/actions/runs/1997533482

[junyer]

Yikes! Digging... (I had run bazel test //:all //test:all //tools:all locally before posting this PR and everything passed, so I'm confused now.)

[dmah42]

yeah, and all the same tests ran on CI on the pull request too.

[junyer]

Ahh. We need to omit these as well:

posix_copts = [
    "-fvisibility=hidden",
    "-fvisibility-inlines-hidden",
]

I'm still baffled as to why this didn't break last night.