Skip to content

fix: unwrap error for os.IsNotExist #2094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2018
Merged

fix: unwrap error for os.IsNotExist #2094

merged 1 commit into from
Nov 7, 2018

Conversation

orisano
Copy link
Contributor

@orisano orisano commented Nov 7, 2018

@orisano orisano mentioned this pull request Nov 7, 2018
Merged
sashankreddya
sashankreddya reviewed Nov 7, 2018
View reviewed changes
Copy link
Collaborator

@sashankreddya sashankreddya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Can you add some UT's for error conditions ?

@dashpole
Copy link
Collaborator

dashpole commented Nov 7, 2018

/ok-to-test

dashpole
dashpole approved these changes Nov 7, 2018
View reviewed changes
Copy link
Collaborator

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dashpole dashpole merged commit 13e3e83 into google:master Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole approved these changes

@sashankreddya sashankreddya sashankreddya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@orisano @dashpole @sashankreddya @k8s-ci-robot