Add LateFunctionBinding declaration and fix constant folding#1117
Merged
Conversation
Collaborator
|
/gcbrun |
zeitgeist87
force-pushed
the
constant_folding_fix
branch
from
83720e3 to
5d7f09b
Compare
zeitgeist87
changed the title
Contributor
Author
|
@TristonianJones I added the |
zeitgeist87
force-pushed
the
constant_folding_fix
branch
2 times, most recently
from
bbb7627 to
caacded
Compare
Collaborator
|
/gcbrun |
Adds the declaration for LateFunctionBindings, which can be used to indicate to the Runtime and the Optimizers that the function will be bound at runtime through the Activation. This lets the constant folding optimizer know that the function potentially has side effects and cannot be folded. Without this the optimization will fail with an error for late bound functions where all arguments are constants. The implementation for late bound functions will be added in a subsequent commit.
zeitgeist87
force-pushed
the
constant_folding_fix
branch
from
caacded to
e5d292c
Compare
Collaborator
|
/gcbrun |
TristonianJones
approved these changes
Apr 14, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some functions are intended to have side effects and therefore should not be folded even if all parameters are constants. Currently the constant folding optimizer throws an error if such a function does not provide an implementation. This change allows functions with side effects to return Unknown.