Fix handling of function declarations in loops with let/consts #1127
Conversation
| @@ -708,6 +708,46 @@ public void testDoWhileForOfCapturedLet() { | |||
| "} while (false);")); | |||
| } | |||
|
|
|||
| public void testIssue1124() { | |||
There was a problem hiding this comment.
I think there's a convention that "issue 1124" means 1124 on code.google.com. Let's add a comment with a link so it's unambiguous.
| @@ -343,6 +343,10 @@ private void transformLoopClosure() { | |||
| } | |||
|
|
|||
| // Change reference to GETPROP. | |||
There was a problem hiding this comment.
Now this comment is misplaced.
|
Can you make sure the pull request description is thorough since that will end up being the CL description internally? |
|
I assume "pull request description" is just the first comment? |
|
Not sure but I'm seeing this now, which is much better :)
|
|
Sounds good :) |
|
Should we merge this? |
| " ($jscomp$loop$0.x)();", | ||
| " };", | ||
| " }($jscomp$loop$0);", | ||
| " $jscomp$loop$0 = {x:$jscomp$loop$0.x};", |
There was a problem hiding this comment.
This seems quite strange but I guess that's not really related to this CL.
Fix handling of function declarations in loops with let/consts
Convert function declaration to variable declaration so that the IIFE can still be applied.
Unmark calls to captured functions like $jscomp$loop.x() as FREE_CALL.
Fixes #1124