Update async await transpilation to avoid captures of super
#3103
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -142,6 +142,73 @@ public void testInnerSuperReference() { | |
| "}")); | ||
| } | ||
|
|
||
| @Test | ||
| public void testInnerSuperCallEs2015Out() { | ||
| setLanguageOut(LanguageMode.ECMASCRIPT_2015); | ||
| test( | ||
| lines( | ||
| "class A {", | ||
| " m() {", | ||
| " return this;", | ||
| " }", | ||
| "}", | ||
| "class X extends A {", | ||
| " async m() {", | ||
| " return super.m();", | ||
| " }", | ||
| "}"), | ||
| lines( | ||
| "class A {", | ||
| " m() {", | ||
| " return this;", | ||
| " }", | ||
| "}", | ||
| "class X extends A {", | ||
| " m() {", | ||
| " const $jscomp$async$this = this;", | ||
| " const $jscomp$async$super$get$m =", | ||
| " () => Object.getPrototypeOf(this.constructor).prototype.m;", | ||
|
There was a problem hiding this comment. Couldn't we just get the prototype directly from () => Object.getPrototypeOf(this).m;There was a problem hiding this comment. Unfortunately not. See the comments in the following snippet: class Base {
static foo() { console.log('base foo'); }
bar() { console.log('base bar'); }
}
class Child extends Base {
static foo() {
console.log(Object.getPrototypeOf(this), Object.getPrototypeOf(this).foo);
Object.getPrototypeOf(this).foo.call(this);
}
bar() {
console.log(Object.getPrototypeOf(this), Object.getPrototypeOf(this).bar);
Object.getPrototypeOf(this).bar(); // logs out "base bar" appropriately
Object.getPrototypeOf(this).bar.call(this); // infinitely loops and locks up the Chrome tab!
}
}There was a problem hiding this comment. Ah, I see my mistake. I wonder which is the safer choice in the face of code that mucks around with prototypes? There was a problem hiding this comment. Discussed this with @concavelenz Would you be willing to make that change? There was a problem hiding this comment. Of course - done. |
||
| " return $jscomp.asyncExecutePromiseGeneratorFunction(", | ||
| " function* () {", | ||
| " return $jscomp$async$super$get$m().call($jscomp$async$this);", | ||
| " });", | ||
| " }", | ||
| "}")); | ||
| } | ||
|
|
||
| @Test | ||
| public void testInnerSuperCallStaticEs2015Out() { | ||
| setLanguageOut(LanguageMode.ECMASCRIPT_2015); | ||
| test( | ||
| lines( | ||
| "class A {", | ||
| " static m() {", | ||
| " return this;", | ||
| " }", | ||
| "}", | ||
| "class X extends A {", | ||
| " static async m() {", | ||
| " return super.m();", | ||
| " }", | ||
| "}"), | ||
| lines( | ||
| "class A {", | ||
| " static m() {", | ||
| " return this;", | ||
| " }", | ||
| "}", | ||
| "class X extends A {", | ||
| " static m() {", | ||
| " const $jscomp$async$this = this;", | ||
| " const $jscomp$async$super$get$m = () => Object.getPrototypeOf(this).m;", | ||
| " return $jscomp.asyncExecutePromiseGeneratorFunction(", | ||
| " function* () {", | ||
| " return $jscomp$async$super$get$m().call($jscomp$async$this);", | ||
| " });", | ||
| " }", | ||
| "}")); | ||
| } | ||
|
|
||
| @Test | ||
| public void testNestedArrowFunctionUsingThis() { | ||
| test( | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any link we could insert here pointing to the MS Edge bug?
We'd really like to be able to track when the MS Edge bug gets fixed, or if it's already fixed and we're just stuck because of installed browsers not getting the fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created one and added the link