rename Intrinsic::getDeclaration to Intrinsic::getOrInsertDeclaration #1406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is needed after LLVM change llvm/llvm-project#111752 |
- Rename Intrinsic::getDeclaration to Intrinsic::getOrInsertDeclaration - Update one test to avoid disabling int8 Bug: crbug.com/373696543
dneto0
commented
Oct 16, 2024
| @@ -1,4 +1,4 @@ | |||
| // RUN: clspv %target %s -o %t.spv -module-constants-in-storage-buffer -int8=0 | |||
There was a problem hiding this comment.
@rjodinchr observed that Clang is inserting explicit padding members.
In this case we now have an i8 first member, a [3 x i8] inserted second member. Everything breaks when artificially trying to remap i8 to u32. Use the default, which is actually support i8.
rjodinchr
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update LLVM
Bug: https://crbug.com/373696543