-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fa: Add more Persian translations #1341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
What is the problem with line 1027 po/fa.po ?! |
The problem is that the wrapping changed. Can you please merge in the latest I just updated that file with instructions for how to auto-format the PO files. In short, you need to
|
"[](https://github.com/" | ||
"google/comprehensive-rust/actions/workflows/build.yml?query=branch%3Amain)" | ||
"[](https://github.com/google/" | ||
"comprehensive-rust/actions/workflows/build.yml?query=branch%3Amain)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the kind of change that should not happen. If you install dprint
and the Gettext tools, you can run dprint fmt
to fix it.
Hi @javad-jafari, please add Also, please say hello to @DannyRavi and @mbpouri there — they are two other volunteers who are interested in this translation. I'll try to find more people who can help out, but the three of you should coordinate with each other for now. |
Hi @mgeisler. |
Awesome! Can you start by reading through the changes here and add GitHub suggestions for anything you think should be fixed? @henrif75 will invite you and the others to work on the repository so that you can approve PRs without having to rely on me. |
@javad-jafari, you should run |
It's awesome, I agree. |
Part of #671.