zh-CN: fix fuzzy sentences #1343
Conversation
SwiftSIQI
requested review from
suetfei,
wnghl,
anlunx,
kongy,
NoahDragon,
superwhd and
emmali01
as code owners
|
Based on what happened before, the other reviewers were so slow to respond that my PR never got merged in. |
If this proposal is acceptable, I think I'll be able to translate the entire Chinese version in about a week's time. |
|
Hey @SketchK, as you can imagine, neither @henrif75 nor myself speak Chinese... so we've been reliant on the help of others like yourself who do. We have found those volunteers both internally at Google and externally. I'm sorry that your PRs have been waiting — I guess the people who helped out so far have become busy with other things. I'll try writing them and see if we can revive this. I'm against blindly accepting the translation since I've seen myself how helpful it can be to have another pair of eyes look things over. I make a ton of typos when I write anything, so I've benefited from the reviews of the Danish translation 😄 However, if we cannot find anyone to help here, then merging your PRs is definitely better than not. Let us see if we can reach the old translators in the next few days? @henrif75, related to this, I suggest we remove people from the |
|
I agree @mgeisler with cleaning up the |
| @@ -2024,7 +2024,7 @@ msgstr "" | |||
| #: src/welcome-day-1.md:24 | |||
| msgid "" | |||
| "The questions will likely mean that we talk about things ahead of the slides." | |||
| msgstr "有些问题会导致我们提前谈到后面的内容" | |||
| msgstr "有些问题会导致我们提前谈到后面的内容." | |||
There was a problem hiding this comment.
If you use Poedit locally, you'll be prompted to make this change, or you'll be warned of an error! @kongy
There was a problem hiding this comment.
Ah, interesting! That looks like a problem with Poedit and we should ignore the error in this case.
I created vslavik/poedit#809 for this in the Poedit repository. Perhaps they have a workaround.
There was a problem hiding this comment.
Hi @SketchK, could you reply on vslavik/poedit#809 to explain what you did to get the warning?
There was a problem hiding this comment.
Hi @SketchK, could you reply on vslavik/poedit#809 to explain what you did to get the warning?
OK, Sir, I write something in that issue @mgeisler
There was a problem hiding this comment.
@SketchK, please apply the suggestion by @kongy above so we can resolve this comment.
| @@ -2054,7 +2054,7 @@ msgstr "" | |||
|
|
|||
| #: src/welcome-day-1.md:36 | |||
| msgid "Morning: 9:00 to 12:00," | |||
| msgstr "早上：9:00 到 12:00，" | |||
| msgstr "早上：9:00 到 12:00," | |||
There was a problem hiding this comment.
Why change to English comma?
There was a problem hiding this comment.
If you use Poedit locally, you'll be prompted to make this change, or you'll be warned of an error! @kongy
There was a problem hiding this comment.
@SketchK, let's ignore the warning — if you find a way to turn it off, please help us document it.
There was a problem hiding this comment.
Please edit it back to use ， and just ignore the warning for now.
| @@ -19387,7 +19387,7 @@ msgstr "" | |||
|
|
|||
| #: src/glossary.md:72 | |||
| msgid "mutable:" | |||
| msgstr "可变" | |||
| msgstr "可变:" | |||
There was a problem hiding this comment.
This change is inconsistent with others, like line 19382 and 19377. I agree this need to be changed, but it is better to change all related in a bulk.
There was a problem hiding this comment.
@NoahDragon Yes, This commit is to resolve Poedit's warning, so you may wander why, but all of it is suggestion of Poedit
There was a problem hiding this comment.
Thank you! I would recommend to separate the Poedit linter check warning fix into another PR. These warnings are not really useful for Chinese translation, and have many discussion already:
- https://stackoverflow.com/questions/44644152/how-to-hide-silly-warnings-in-poedit
- Change wording of common translation mistake warnings vslavik/poedit#395
- Option to disable useless warnings? vslavik/poedit#445
@mgeisler Do you think if it is okay to ingore the linter warnings? Please ignore this, I saw your comment in another thread.
There was a problem hiding this comment.
Thanks @NoahDragon for looking this up! I would be very happy to have language-specific advice in STYLE or TRANSLATIONS or somewhere else — whatever feels most natural to the language communities.
|
Hey @SketchK, I removed myself and @henrif75 as reviewers — we're not actually qualified to skim through the Chinese here 😄 I think you've already gotten some great actionable feedback from @NoahDragon and @kongy and you should just apply those fixes. When that is done, one of them will approve the PR and we can merge it. Thanks for all the work you do here! |
|
Hi @SketchK, will you resubmit this as another PR? I had the impression that the changes were good (based on the reviews of @kongy and @NoahDragon), so I would be sad to lose them! |
|
@mgeisler |
Oh, I understand now! Thanks for the explanation. |
Hi, @henrif75
The diff looks normal now!
Thank for your work!