-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Fix typo: missing n in unknown #1344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey all! A small note: you should never edit the The problem is that the translations are not using the current English text. Instead they're using the English text as it looked at the time mentioned in the POT-Creation-Date field at the top of the PO file. This was implemented in #1243. We should revert the edits to the PO files to fix this. |
Reverts #1344. The edit to the Markdown file has been kept since we _do_ want to fix the typo!
I created #1347 to remove the edits to the PO files. Perhaps we can create a check somehow which catches this in the future? We've have a few PRs like this where people do the natural thing and fix a typo in all files where it occurs. |
Do we want to search for any edits of PO files, or specific changes of anything inbetween the
I'm assuming only everything between |
Good question... The tricky thing is that we do change the
Yes, correct: the text there is the original English text. It has to match the text in the Markdown for us to translate it correctly (via mdbook-i18n-helpers). Saying this, I get an idea : I think we can spot correct edits of the |
See discussion in #1344. This checks that all `.po` files changed in pull requests either contain changes in POT-Creation-Date (i.e. are run by the specific tool which should change msgid's), or don't change msgid's (by checking that each line changed is NOT between msgid and msgstr) I have tested this on my fork, see [valid changes](https://github.com/noamzaks/comprehensive-rust/pull/1/files) where the action passes, and [invalid changes](https://github.com/noamzaks/comprehensive-rust/pull/2/files) where it doesn't. The action also has output for failing/passing: [passing](https://github.com/noamzaks/comprehensive-rust/actions/runs/6488171290/job/17620037473?pr=1) [failing](https://github.com/noamzaks/comprehensive-rust/actions/runs/6488175171/job/17620050716?pr=2)
No description provided.