Add dprint step to TRANSLATIONS.md
#1363
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes Update TRANSLATIONS.MD with `dprint fmt` step google#1362
|
Ref.: #1359 |
|
Need to address an error following the described procedure |
|
Nvm, #1359 already adds instructions to TRANSLATIONS.md 🤦 |
mgeisler
reviewed
Oct 16, 2023
Comment on lines
+45
to
+49
| On MacOS with [Homebrew](https://brew.sh/), you can install with: | ||
|
|
||
| ```shell | ||
| brew install gettext | ||
| ``` |
There was a problem hiding this comment.
Nice, I think it would be good to add instructions for MacOS like you do here.
mgeisler
reviewed
Oct 16, 2023
Comment on lines
+172
to
+179
| ### Formatting a Translation | ||
|
|
||
| You should run `dprint` on your `.po` file to ensure it is formatted correctly. | ||
| You can do this with: | ||
|
|
||
| ```shell | ||
| dprint fmt po/xx.po | ||
| ``` |
There was a problem hiding this comment.
This is also a nice thing to add!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Update TRANSLATIONS.MD with
dprint fmtstep #1362