Skip to content

Publish Korean translation #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mgeisler
Copy link
Collaborator

This adds the Korean translation to the list of published translations!

This adds the Korean translation to the list of published translations!
@mgeisler mgeisler requested a review from jiyongp January 30, 2023 16:59
@mgeisler
Copy link
Collaborator Author

Hi @jiyongp and @keispace, as far as I understand, we can start publishing the Korean translation, right?

@jiyongp
Copy link
Collaborator

jiyongp commented Jan 31, 2023

I wish we have a few more rounds before we publish it. I haven't finished proof-reading and revising it. See #302 for my progress.

@mgeisler
Copy link
Collaborator Author

I wish we have a few more rounds before we publish it. I haven't finished proof-reading and revising it.

Okay, we can wait a bit — though we can also refine it as we get more PRs from the community 😄

@jiyongp
Copy link
Collaborator

jiyongp commented Jan 31, 2023

That's fair. Then let me finish proof-reading and revising the content for first day at least. Then we can publish for broader contribution.

@mgeisler
Copy link
Collaborator Author

Superseded by #428 which also updates the new language picker.

@mgeisler mgeisler closed this Feb 17, 2023
@mgeisler mgeisler deleted the mgeisler-publish-korean-translation branch March 19, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants