Unified rust version with current release#6149
Closed
krojew wants to merge 1 commit intogoogle:masterfrom
Closed
Conversation
Collaborator
|
Yes, that is something @rw wanted.. I don't particularly care either way myself. |
Contributor
Author
|
Do you know why? This makes it non-obvious what version is actually supported. |
Closed
Collaborator
|
There should be a test of some kind that fails when the crate falls out of sync with flatc's version. |
Contributor
Author
|
We would need to do the same for other languages then. |
This was referenced Feb 9, 2021
Contributor
|
This pull request is stale because it has been open 6 months with no activity. Please comment or this will be closed in 14 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, Rust FB has different versioning scheme than FB proper.
@rw @aardappel r?