This repository was archived by the owner on Oct 13, 2025. It is now read-only.
fix bug: the old position lost if widget unmounted from the tree. #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if a list view using linked scroll controller is unmounted in some cases, when it is remounted the position will lost. This commit can fix it.
jamesderlin
added
the
p: linked_scroll_controller
Contributor
|
Please also update CHANGELOG and pubspec version. |
Contributor
|
@robertoscaramuzzi Could you please take a look at this? |
fryette
suggested changes
Dec 1, 2020
|
|
||
| if (oldPosition == null && _controllers._attachedControllers.isNotEmpty) { | ||
| final position = _controllers._attachedControllers.first.position; | ||
| if (newPosition.minScrollExtent == null && |
There was a problem hiding this comment.
it's throwing an exception because minScrollExtent cannot be null, and if private _minScrollExtent null->exception throws
|
These changes broke the package |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
if a list view using linked scroll controller is unmounted in some cases, when it is remounted the position will lost. This commit can fix it.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.flutter testpass.flutter analyzedoes not report any problems on my PR.