feat: Implement Compute Security Policies Crawler #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trap script. Add compute securit config in example config
mshudrak
reviewed
Dec 13, 2023
mshudrak
reviewed
Dec 13, 2023
mshudrak
approved these changes
Dec 26, 2023
Contributor
mshudrak
left a comment
mshudrak
left a comment
There was a problem hiding this comment.
LGTM with two minor nits. Once you fix it, we can push the commit. Thanks again for implementing it.
| except Exception: | ||
| logging.info("Failed to enumerate compute security policies in the %s", project_name) | ||
| logging.info(sys.exc_info()) | ||
| return security_policies_list No newline at end of file |
Contributor
There was a problem hiding this comment.
Pls add new line at the end.
Contributor
Author
There was a problem hiding this comment.
Fixed this with new commit
| # update default rule to deny all traffic (default rule has priority 2147483647) | ||
| gcloud compute security-policies rules update 2147483647 \ | ||
| --security-policy test-security-policy \ | ||
| --action "deny-404" No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
Fixed this with new commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue #247 . Added support for Compute/securitypolicies resource
Changes Made
cloud_security_policies_crawler.pyTesting
App ran successfully during local testing