docstore: Opentelemetry migration of docstore #3550
+311
−460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jba
reviewed
Apr 15, 2025
docstore/docstore.go
Outdated
| gcdkotel.MethodKey.String("ActionList.Do"), | ||
| gcdkotel.ProviderKey.String(l.coll.tracer.Provider), | ||
| } | ||
| completedCallsCounter.Add(context.Background(), 1, metric.WithAttributes(attr...)) |
docstore/docstore.go
Outdated
| gcdkotel.ProviderKey.String(l.coll.tracer.Provider), | ||
| } | ||
| latencyHistogram.Record( | ||
| context.Background(), |
docstore/query.go
Outdated
| gcdkotel.MethodKey.String("Query.Get"), | ||
| gcdkotel.ProviderKey.String(q.coll.tracer.Provider), | ||
| } | ||
| completedCallsCounter.Add(context.Background(), 1, metric.WithAttributes(attr...)) |
pramineni01
suggested changes
Apr 18, 2025
docstore/docstore.go
Outdated
Comment on lines
379
to
380
| var startTime time.Time | ||
| var span trace.Span |
There was a problem hiding this comment.
Could these two be defined in the scope of
if withTracing {} below. Seems we dont need them outside the scope.
docstore/otel_test.go
Outdated
Comment on lines
65
to
68
| // Skip span check as span attributes might have changed during migration | ||
| // if !providerFound { | ||
| // t.Errorf("did not see span with provider=%s", driver) | ||
| // } |
docstore/query.go
Outdated
Comment on lines
219
to
220
| var startTime time.Time | ||
| var span trace.Span |
There was a problem hiding this comment.
Move into if withTracing {...} scope below?
…/go-cloud into otel-migration-docstore
|
@pramineni01 @jba before this pr is good for review please take a look at #3557. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Micro PR to migrate monolith : #3539
PR affects :