Provide detailed instructions on contributing

[naveensrinivasan]

The contributing.md needs to have more detailed instructions on how to contribute and run tests.

The document just mentions to run

./hack/presubmit.sh

And running that produces failed tests.

--- FAIL: TestGcloudErrors (0.00s)
    --- FAIL: TestGcloudErrors/error (0.00s)
        auth_test.go:113: wanted error, got nil
    --- FAIL: TestGcloudErrors/badoutput (0.00s)
        auth_test.go:113: wanted error, got nil
    --- FAIL: TestGcloudErrors/badexpiry (0.00s)
        auth_test.go:113: wanted error, got nil
--- FAIL: TestGcloudSuccess (0.00s)
    auth_test.go:139: wanted token "mytoken", got ""
--- FAIL: TestKeychainGCRandAR (0.00s)
    --- FAIL: TestKeychainGCRandAR/cases[0] (0.00s)
        auth_test.go:205: expected not anonymous auth for {gcr.io true}, got: &{}
        auth_test.go:216: expected not anonymous auth for {gcr.io true}, got: &{}
    --- FAIL: TestKeychainGCRandAR/cases[1] (0.00s)
        auth_test.go:205: expected not anonymous auth for {us.gcr.io true}, got: &{}
        auth_test.go:216: expected not anonymous auth for {us.gcr.io true}, got: &{}
    --- FAIL: TestKeychainGCRandAR/cases[2] (0.00s)
        auth_test.go:205: expected not anonymous auth for {eu.gcr.io true}, got: &{}
        auth_test.go:216: expected not anonymous auth for {eu.gcr.io true}, got: &{}
    --- FAIL: TestKeychainGCRandAR/cases[3] (0.00s)
        auth_test.go:205: expected not anonymous auth for {asia.gcr.io true}, got: &{}
        auth_test.go:216: expected not anonymous auth for {asia.gcr.io true}, got: &{}
    --- FAIL: TestKeychainGCRandAR/cases[4] (0.00s)
        auth_test.go:205: expected not anonymous auth for {staging-k8s.gcr.io true}, got: &{}
        auth_test.go:216: expected not anonymous auth for {staging-k8s.gcr.io true}, got: &{}
    --- FAIL: TestKeychainGCRandAR/cases[5] (0.00s)
        auth_test.go:205: expected not anonymous auth for {global.gcr.io true}, got: &{}
        auth_test.go:216: expected not anonymous auth for {global.gcr.io true}, got: &{}
    --- FAIL: TestKeychainGCRandAR/cases[9] (0.00s)
        auth_test.go:205: expected not anonymous auth for {us-docker.pkg.dev true}, got: &{}
        auth_test.go:216: expected not anonymous auth for {us-docker.pkg.dev true}, got: &{}
    --- FAIL: TestKeychainGCRandAR/cases[10] (0.00s)
        auth_test.go:205: expected not anonymous auth for {asia-docker.pkg.dev true}, got: &{}
        auth_test.go:216: expected not anonymous auth for {asia-docker.pkg.dev true}, got: &{}
    --- FAIL: TestKeychainGCRandAR/cases[11] (0.00s)
        auth_test.go:205: expected not anonymous auth for {europe-docker.pkg.dev true}, got: &{}
        auth_test.go:216: expected not anonymous auth for {europe-docker.pkg.dev true}, got: &{}
    --- FAIL: TestKeychainGCRandAR/cases[12] (0.00s)
        auth_test.go:205: expected not anonymous auth for {us-central1-docker.pkg.dev true}, got: &{}
        auth_test.go:216: expected not anonymous auth for {us-central1-docker.pkg.dev true}, got: &{}
--- FAIL: TestKeychainError (0.00s)
    auth_test.go:234: expected err, got: <nil>
FAIL
FAIL	github.com/google/go-containerregistry/pkg/v1/google	0.417s

More detailed instructions would be helpful.

[jonjohnsonjr]

Can you tell me more about the machine you're running on?

I had to disable arm64 for these tests for a similar reason: 12de591

Those tests shell out to themselves to simulate invoking an external binary, which seemed to work for everything but arm64.

[naveensrinivasan]

I am running on Mac OSX.

[naveensrinivasan]

This is my head commit 7682012 (HEAD -> master, upstream/master, origin/master, origin/HEAD)

[jonjohnsonjr]

Do you have the new M1 chip or an older amd64 one?

[naveensrinivasan]

I have a Intel

[jonjohnsonjr]

Does #909 get ./hack/presubmit.sh to pass? I am happy to merge that until we can figure out what's wrong.

[naveensrinivasan]

#909 Fixed the issue.