Skip to content

feat: Add new fields and options to secret scanning structs #3548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 15, 2025

Conversation

mdfleury-wbd
Copy link
Contributor

Added some new fields to secret scanning alerts

@gmlewis gmlewis changed the title feat: adding new fields and options in secret scanning feat: Add new fields and options to secret scanning structs Apr 14, 2025
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.23%. Comparing base (6a7684f) to head (e7a50e8).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3548   +/-   ##
=======================================
  Coverage   91.23%   91.23%           
=======================================
  Files         183      183           
  Lines       16053    16053           
=======================================
  Hits        14646    14646           
  Misses       1231     1231           
  Partials      176      176           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis
Copy link
Collaborator

gmlewis commented Apr 15, 2025

Please run:

  • ./script/fmt.sh
  • ./script/generate.sh
    and push the changes to this PR, then we should be good to go.

@mdfleury-wbd
Copy link
Contributor Author

The broken tests seem to be coming from #3551
which is here
https://github.com/codecov/codecov-action/compare/v5.4.0..v5.4.2

@gmlewis
Copy link
Collaborator

gmlewis commented Apr 15, 2025

The broken tests seem to be coming from #3551 which is here https://github.com/codecov/codecov-action/compare/v5.4.0..v5.4.2

Thank you, @mdfleury-wbd!
I've reverted that change. Would you mind merging the latest master branch into this PR to see if that fixes the problem?

@gmlewis
Copy link
Collaborator

gmlewis commented Apr 15, 2025

Oh wait, I forgot that I can do that... one moment...

@gmlewis
Copy link
Collaborator

gmlewis commented Apr 15, 2025

That fixed it! Woohoo!

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mdfleury-wbd!
LGTM.
Merging.

@gmlewis gmlewis merged commit 687f933 into google:master Apr 15, 2025
7 checks passed
@mdfleury-wbd mdfleury-wbd deleted the add-secret-fields branch April 15, 2025 17:25
@gmlewis
Copy link
Collaborator

gmlewis commented Apr 15, 2025

Just out of curiosity, how often do you cut new releases?

Typically about once per month but we can cut new releases on-demand when there is an urgent need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants