Skip to content

Use new recordIssue: API #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thomasvl merged 4 commits into from
Apr 25, 2022
Merged

Use new recordIssue: API #315

thomasvl merged 4 commits into from
Apr 25, 2022

Conversation

@eytanbiala
Copy link
Contributor

@eytanbiala eytanbiala commented Feb 14, 2022

-[XCTestCase recordFailureWithDescription:inFile:atLine:expected:] is deprecated, and the replacement is recordIssue:

@eytanbiala
Use new recordIssue: API
1e26e64 
-[XCTestCase recordFailureWithDescription:inFile:atLine:expected:] is deprecated, and the replacement is recordIssue:
@thomasvl thomasvl requested a review from dmaclach February 22, 2022 13:10
dmaclach
dmaclach reviewed Feb 22, 2022
View reviewed changes
@eytanbiala eytanbiala requested a review from dmaclach April 6, 2022 13:12
dmaclach
dmaclach requested changes Apr 22, 2022
View reviewed changes
Copy link
Collaborator

@dmaclach dmaclach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for being slow on this. I totally missed it.

eytanbiala
eytanbiala commented Apr 23, 2022
View reviewed changes
Copy link
Contributor Author

@eytanbiala eytanbiala left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for coming back to it, I forgot about it as well :) (next time can send a private CL if that's preferred)

dmaclach
dmaclach approved these changes Apr 25, 2022
View reviewed changes
Copy link
Collaborator

@dmaclach dmaclach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@thomasvl thomasvl merged commit 7a94cde into google:main Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmaclach dmaclach dmaclach approved these changes

+1 more reviewer

@gracemerry gracemerry gracemerry approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eytanbiala @dmaclach @gracemerry @thomasvl