Remove bazelbuild/rules_cc dependency #3574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekmauro
added a commit
that referenced
this pull request
Sep 23, 2021
PiperOrigin-RevId: 397995447
dneto0
added a commit
to dneto0/effcee
that referenced
this pull request
Dec 21, 2022
Stop using an external rules_cc dependency. Use internal C/C++ rules instead. - Follows googletest in doing this. google/googletest#3574 - See also: bazel-contrib/rules_go#2950 This appears necessary for compatibility with Bazel 5.0.0 and Bazel 6.0.0 Update to googletest-release-1.12.1, the last release that only needs a C++11 compiler, and doesn't require C++14. Update to re2-2022-12-01 I have successfully built and tested effcee with this configuration on Linux x86-64 with Bazel 5.0.0 and Bazel 6.0.0.
dneto0
added a commit
to google/effcee
that referenced
this pull request
Dec 21, 2022
Stop using an external rules_cc dependency. Use internal C/C++ rules instead. - Follows googletest in doing this. google/googletest#3574 - See also: bazel-contrib/rules_go#2950 This appears necessary for compatibility with Bazel 5.0.0 and Bazel 6.0.0 Update to googletest-release-1.12.1, the last release that only needs a C++11 compiler, and doesn't require C++14. Update to re2-2022-12-01 I have successfully built and tested effcee with this configuration on Linux x86-64 with Bazel 5.0.0 and Bazel 6.0.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bazelbuild/rules_cc was put on hold
It seems the recommended way is now to use native cc rules
More info here