add dartfmt support #202
Merged
add dartfmt support #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,6 +33,51 @@ Directory getSdkDir([List<String> cliArgs]) => cli_util.getSdkDir(cliArgs); | |||
|
|
|||
| File get dartVM => joinFile(sdkDir, ['bin', _sdkBin('dart')]); | |||
|
|
|||
| /// Utility tasks for for getting information about the Dart SDK and invoking | |||
| /// dart applications. | |||
| class Dart { | |||
There was a problem hiding this comment.
Should this class be called Dart or DartSdk?
There was a problem hiding this comment.
I chose Dart since it wraps the dart executable, similar to how Pub wraps pub and Dart2js wraps dart2js. However we do have Analyzer for dartanalyzer, so we could do Dart2js -> Compiler and Dart -> Vm, but I kind of think the Dart prefix is nice.
There was a problem hiding this comment.
Hmm, it might be interesting to namespace all the sdk stuff, so:
class Sdk {
/// Defaults the path to the current SDK.
Sdk([String path]);
static Directory get dir;
final Vm vm;
final Compiler compiler;
final Analyzer analyzer;
final Formatter formatter;
}
final Sdk sdk = new Sdk();print('Sdk dir: ${sdk.dir}');
sdk.vm.run(...);
sdk.compiler.compile(...);
sdk.analyzer.analyze(...);
sdk.formatter.format(...);There was a problem hiding this comment.
I left this as Dart, and removed the location static field. That would apply to a wrapper around the dartsdk, but not one around the dartvm.
|
Filed my review comments as #204, let's discuss there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #168.
@seaneagan
Write a wrapper around the
dartfmtSDK tool. This is scoped to just exposing what's in the SDK .The user still has the option of using aPubAppwrapper around thedart_styletool.(the
AnalyzerandDart2jsclasses are unchanged; they just changed locations within the file)