Add spotless plugin#2537
Merged
Merged
Conversation
Excludes: - Java17RecordTest.java - Java17RecordReflectionTest.java
MaicolAntali
commented
Nov 7, 2023
Comment on lines
+140
to
+152
| <formats> | ||
| <format> | ||
| <includes> | ||
| <include>*.md</include> | ||
| <include>.gitignore</include> | ||
| </includes> | ||
| <trimTrailingWhitespace/> | ||
| <endWithNewline/> | ||
| <indent> | ||
| <spaces>true</spaces> | ||
| <spacesPerTab>4</spacesPerTab> | ||
| </indent> | ||
| </format> |
Contributor
Author
There was a problem hiding this comment.
I kept the <format> section, let me know if you prefer to remove it (or remove the .md)
Marcono1234
reviewed
Nov 10, 2023
Member
|
Is this ready to merge? |
Contributor
Author
|
If we want keep the |
eamonnmcmanus
approved these changes
Nov 13, 2023
Member
eamonnmcmanus
left a comment
There was a problem hiding this comment.
OK. We can always adjust this later as needed.
Thanks again for doing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add the
spotlessplugins to enforce the Google Java Style Guide.Description
Related with #2284