Remove DateTypeAdapter to avoid code duplication#2546
Merged
eamonnmcmanus merged 1 commit intoNov 19, 2023
Conversation
The same functionality exists in `DefaultDateTypeAdapter` (with some slight overhead), and there is currently code duplication between these classes.
Member
eamonnmcmanus
left a comment
There was a problem hiding this comment.
This is great, thanks! I think I've said before that the way it handles Date is probably Gson's biggest mistake. We can't easily fix that, but we can at least make it easier to improve the situation.
The changes look good to me. I'm running this past Google's tests in case that turns anything up.
9 tasks
eamonnmcmanus
approved these changes
Nov 19, 2023
Member
eamonnmcmanus
left a comment
There was a problem hiding this comment.
Google's internal tests all passed.
9 tasks
tibor-universe
pushed a commit
to getuniverse/gson
that referenced
this pull request
Sep 14, 2024
The same functionality exists in `DefaultDateTypeAdapter` (with some slight overhead), and there is currently code duplication between these classes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Remove the internal
DateTypeAdapterclass to avoid code duplicationDescription
The same functionality exists in
DefaultDateTypeAdapter(with some slight overhead though), and there is currently code duplication between these classes.The code in
DefaultDateTypeAdapterand the way it is used now as replacement should behave the same wayDateTypeAdapterdid, but feel free to double-check in case I overlooked something.Checklist
This is automatically checked by
mvn verify, but can also be checked on its own usingmvn spotless:check.Style violations can be fixed using
mvn spotless:apply; this can be done in a separate commit to verify that it did not cause undesired changes.null@since $next-version$(
$next-version$is a special placeholder which is automatically replaced during release)TestCase)mvn clean verify javadoc:jarpasses without errors