feature: allow undefined types as long as they have a converter #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Types from Platform-specific libraries (like dart:ui in Flutter) don't resolve properly during code generation. See dart-lang/build#733 This update allows undefined types to be handled with custom to/fromJson for an associated field Fixes #236
jakemac53
reviewed
Jun 21, 2018
| @JsonSerializable(createFactory: false) | ||
| class UnknownFieldTypeToJsonOnly { | ||
| // ignore: undefined_class | ||
| Bob number; |
There was a problem hiding this comment.
Note that in Dart 2 this will be a compile time error so migrating this test to use modular kernel will likely be an issue, but you could cross that bridge when you come to it (or possibly exclude this file from that builder).
There was a problem hiding this comment.
ack – it was either this or depend on Flutter in the Test 😄
jakemac53
approved these changes
Jun 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types from Platform-specific libraries (like dart:ui in Flutter)
don't resolve properly during code generation.
See dart-lang/build#733
This update allows undefined types to be handled with custom
to/fromJson for an associated field
Fixes #236