Skip to content

panics when struct that shadows another struct is passed in #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chr0n1x opened this issue Jul 20, 2015 · 4 comments
Closed

panics when struct that shadows another struct is passed in #1

chr0n1x opened this issue Jul 20, 2015 · 4 comments

Comments

@chr0n1x
Copy link

chr0n1x commented Jul 20, 2015

Panics @ line 126 of response.go (out of index error on modelValue.Field(i))

Example code:

type A struct {
    AString string `jsonapi:"attr,aString"`
}

type B struct {
    A
    BString string `jsonapi:"attr,bString"`
}
@shwoodard
Copy link
Contributor

Looking into this.

@shwoodard
Copy link
Contributor

@shwoodard
Copy link
Contributor

@chr0n1x Can I get an lgtm?

@chr0n1x
Copy link
Author

chr0n1x commented Jul 21, 2015

@shwoodard looks GREAT to me. Thanks for the quick patch & work! :D

msabramo pushed a commit to msabramo/jsonapi that referenced this issue Jan 25, 2018
Test more things in TestUnmarshalNestedStruct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants