Skip to content

fix: windows compile fix on vs2022 #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Simonhancrew wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: windows compile fix on vs2022 #1214

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d4a22b
fix: windows compile fix
Simonhancrew Nov 10, 2024
dafd78f
Merge branch 'google:main' into main
Simonhancrew Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,12 @@ if(HAVE_CLANG_THREAD_SAFETY)
-Werror -Wthread-safety)
endif(HAVE_CLANG_THREAD_SAFETY)

if (WIN32)
target_compile_options(leveldb
PUBLIC
-Wno-deprecated-declarations)
endif(WIN32)

if(HAVE_CRC32C)
target_link_libraries(leveldb crc32c)
endif(HAVE_CRC32C)
Expand Down Expand Up @@ -409,6 +415,11 @@ if(LEVELDB_BUILD_BENCHMARKS)
set(BENCHMARK_ENABLE_TESTING OFF CACHE BOOL "" FORCE)
set(BENCHMARK_ENABLE_EXCEPTIONS OFF CACHE BOOL "" FORCE)
add_subdirectory("third_party/benchmark")
if (WIN32)
target_compile_options(benchmark
PUBLIC
-Wno-invalid-offsetof -Wno-shorten-64-to-32)
endif(WIN32)

function(leveldb_benchmark bench_file)
get_filename_component(bench_target_name "${bench_file}" NAME_WE)
Expand Down