Skip to content

Fix typo #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix typo #491

wants to merge 1 commit into from

Conversation

maflcko
Copy link

@maflcko maflcko commented Jul 30, 2017

No description provided.

“of of” -> “of”

Mirroring downstream change committed in
bitcoin/bitcoin@0a5a6b9
e9b0b96b0a

(cherry picked from commit 2953978)
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@maflcko
Copy link
Author

maflcko commented Jul 30, 2017

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@dimitris-t
Copy link

I signed it!

1 similar comment
@maflcko
Copy link
Author

maflcko commented Jul 30, 2017

I signed it!

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@dimitris-t
Copy link

As the commit author I approve of this pull request.

@cmumford
Copy link
Contributor

@googlebot rescan

@cmumford
Copy link
Contributor

Thanks for the PR @MarcoFalke. I didn't notice this earlier and this typo was just recently fixed in 71ed7c4.

@cmumford cmumford closed this Apr 12, 2019
@maflcko maflcko deleted the Mf1707-leveldbCherryPickTypo branch April 12, 2019 18:02
maochongxin pushed a commit to maochongxin/leveldb that referenced this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants