Integrate to the bootstrap process of rust-lang/rust

[dalance]

This PR changes the followings for rust-lang/rust#124731:

• Export Gettext preprocessor
• Fix "hidden lifetime parameters in types are deprecated" error
• Downgrade the minimum required version of regex to 1.9.4

Closes #191

[codecov-commenter]

Codecov Report

❌ Patch coverage is 6.45161% with 58 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.74%. Comparing base (2b14491) to head (b44611b).
⚠️ Report is 98 commits behind head on main.

Files with missing lines	Patch %	Lines
i18n-helpers/src/preprocessors/gettext.rs	0.00%	50 Missing ⚠️
i18n-helpers/src/bin/mdbook-gettext.rs	0.00%	8 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
- Coverage   90.27%   89.74%   -0.54%     
==========================================
  Files          12       13       +1     
  Lines        3034     3052      +18     
  Branches     3034     3052      +18     
==========================================
  Hits         2739     2739              
- Misses        207      225      +18     
  Partials       88       88              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[mgeisler]

We might get a PR from the dependabot, but we can then tell it to ignore the 1.10 releases.

[mgeisler]

I'm not a fan of giving multiple public names for the same thing — could you instead make the module private?

Suggested change

	pub mod gettext;
	pub use gettext::Gettext;
	mod gettext;
	pub use gettext::Gettext;

[dalance]

I've fixed it.

[mgeisler]

Would this work as well:

Suggested change

	let gettext = Gettext;
	if gettext.supports_renderer(renderer) {
	if Gettext::supports_renderer(renderer) {

[dalance]

I can't change the definition of supports_renderer and run because they are defined as methods of Preprocessor trait at https://docs.rs/mdbook/latest/mdbook/preprocess/trait.Preprocessor.html.

I can define another static method like impl_supports_renderer, and change it to Gettext::impl_supports_renderer,
but it may be redundant.

[mgeisler]

Ah, I see now! The syntax I used above would only work if the supports_renderer method had no &self argument.

Then let's merge this PR as it is — and then later change the code here to create a single Gettext value and pass this around. That would be a little more natural, I think (thought it would just be a small refactor).

[mgeisler]

Like above, I think we don't need the variable:

Suggested change

	let gettext = Gettext;
	let book = gettext.run(&ctx, book)?;
	let book = Gettext::run(&ctx, book)?;

[mgeisler]

Hi @dalance, can you try out this change and see if it compiles? If so, please add it to the PR. Thanks!

[mgeisler]

Hi @dalance, thanks a lot for the PR! I would like to merge it after the small conflicts are resolved.

[dalance]

Thank you for your review. I resolved conflict and fixed the module visibility.

[mgeisler]

We should make a release with this change — @kdarkhan, are there any other changes or fixes which you would like us to wait for? I think we could get #195 merged and then do the release.

[kdarkhan]

We should make a release with this change — @kdarkhan, are there any other changes or fixes which you would like us to wait for? I think we could get #195 merged and then do the release.

Nothing from my side. I am ok with the release with 195 merged.