Revert mixin type inference #761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdata
commented
Sep 18, 2019
| "experimentalDecorators": true, | ||
| "noErrorTruncation": true | ||
| "noErrorTruncation": true, | ||
| "declaration": true |
There was a problem hiding this comment.
This should have been enabled previously. Now that it is on, we will see the category of errors this inference pattern raised in google3.
elalish
approved these changes
Sep 18, 2019
elalish
pushed a commit
to elalish/model-viewer
that referenced
this pull request
Feb 4, 2020
Revert mixin type inference (google#761)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, we must revert this part of #747 because it is not compatible with generating external declaration files.
See also microsoft/TypeScript#30355 (comment)