Skip to content

Fix code coverage generation #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jaqx0r opened this issue Jan 28, 2020 · 1 comment
Closed

Fix code coverage generation #290

jaqx0r opened this issue Jan 28, 2020 · 1 comment
Labels
process Issues related to process and CI

Comments

@jaqx0r
Copy link
Contributor

jaqx0r commented Jan 28, 2020

Per golang/go#35781 this is broken in mtail for go 1.13.

Possible fixes:

  • fix the above bug and leave mtail as it is
  • change mtail to use a different coverage system (codecov.io was suggested by @SuperQ)
jaqx0r added a commit that referenced this issue Jan 28, 2020
@jaqx0r
Revert "No longer generate coverage.html."
845192f 
This didn't fix issue #290

This reverts commit 3773d98.
jaqx0r added a commit that referenced this issue Jan 28, 2020
@jaqx0r
Allow the coverage step to fail and not upset the build.
eec0a2a 
Issue #290
@jaqx0r jaqx0r added the process Issues related to process and CI label Jan 31, 2020
@jaqx0r
Copy link
Contributor Author

jaqx0r commented Nov 30, 2020

We moved to codecov and just recently got oss-fuzz coverage as well.

@jaqx0r jaqx0r closed this as completed Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
process Issues related to process and CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaqx0r