OR-Tools + SCIP -> make cc dotnet -> Windows 10, VS 2017 Pro

[TornadoJo]

Hi all,

just my very first issue on github - so have some patience ;-)

• building SCIP worked.
• building OR-Tools with SCIP worked (at the end somehow....)

but I had to overcome several hurdles:
1.)

• in the subdirectory ortools/base status_macros.h is missing
• defining VLOG_EVERY_N_SEC e.g.:
  

  or-tools/ortools/linear_solver/scip_interface.cc

  Line 225 in 4477092

  VLOG_EVERY_N_SEC(1, 10) << "Early abort: SCIP is in error state."; \

  
  and
• defining RETURN_IF_ERROR e.g.:
  

  or-tools/ortools/linear_solver/scip_interface.cc

  Lines 169 to 171 in 4477092

  	util::Status SCIPInterface::CreateSCIP() {
  	RETURN_IF_ERROR(TO_STATUS(SCIPcreate(&scip_)));
  	RETURN_IF_ERROR(TO_STATUS(SCIPincludeDefaultPlugins(scip_)));

  
  needed by "scip_interface.cc" where it includes "ortools/base/status_macros.h" - the same that is excluded in linear_solver.cc#38
  -> I couldn't find it anywhere (on github) so I created a header file defining this two things to make "make cc" work...

2.) In several first tries I added the compilerflag "c++latest" to "CFLAGS = -nologo c++latest....in "Makefile.win.mk#166" to get rid of compiler warnigns in several "make cc"-compiles --result-> several (7) linker errors at the end with added "c++latest"-flag - see attached complete log of the compile...

make.dotnet.log -> (log file represents a "make dotnet" with added status_macros.h and "c++latest" compiler flag added)

This lead to "make dotnet" to fail...

• After creating a (compile compatible) "status_macros.h" on my own and especially removing "c++latest" again from CFLAGS "make cc" and "make dotnet" went okay so far...

Question: What would the content of status_macros.h exactly be to get a valid and complete compile? (or am I missing something else?)

Another minor detail: changed CFLAGS /D__WIN32__ to /D__WIN64__ .... hmm.

[Mizux]

Hi,

Thanks a lot for your feedback !

To be honest the SCIP is not tested on CI (which are public Travis-CI , Appveyor) since SCIP license doesn't allow us to use it (ed you must download it from their website...).

EDIT:

• ortools/base should contains stuff from google internal which is not part of OR-Tools but needed by it.
• VLOG_EVERY_N_SEC is part of "internal" glog but doesn't seems to be public...
• RETURN_IF_ERROR is defined in status_macros.h which is a Google "internal" util methods...
  But as you have noticed it seems we missed few macros (which are only use by SCIP) so we didn't spot it through the others non optional third party solvers (e.g. cbc_interface) ...

I'll try to fix it for v7.1 as well as test the SCIP 6.0.1 against windows build.

note: related to #1115

[TornadoJo]

Hi,

that would be wonderful!

I read #1115

Many tx!

[TornadoJo]

One additional minor bug while creating the Google.OrTools.runtime.win-x64.csproj - file

• I don't exactly remember: could it be that I had to create the root-"or-tools/bin" - directory by hand to get "or-tools.snk"-file and "scip.dll" copied/created there by make correctly

[Mizux]

@TornadoJo strange, it should be created automatically

or-tools/makefiles/Makefile.dotnet.mk

Line 68 in 39f4470

DOTNET_ORTOOLS_SNK := $(BIN_DIR)/or-tools.snk

or-tools/makefiles/Makefile.dotnet.mk

Lines 276 to 282 in 39f4470

	ifneq ($(DOTNET_SNK),)
	$(DOTNET_ORTOOLS_SNK): | $(BIN_DIR)
	$(COPY) $(DOTNET_SNK) $(DOTNET_ORTOOLS_SNK_PATH)
	else
	$(DOTNET_ORTOOLS_SNK): ortools/dotnet/CreateSigningKey/CreateSigningKey.csproj | $(BIN_DIR)
	"$(DOTNET_BIN)" run --project ortools$Sdotnet$SCreateSigningKey$SCreateSigningKey.csproj $S$(DOTNET_ORTOOLS_SNK_PATH)
	endif

[TornadoJo]

@mizuk U r amazing - never seen such a speed in answering!

• Creating "bin" - I saw it but I'm fine with that - could be something on my side - but I'm sure there was an errror moaning about ../bin... on the root-level of "or-tools-7.0" - could not.....

Btw, any chance to get the "original" code of status_macros.h posted here - just for the better feeling :)

kind regards

[Mizux]

@TornadoJo just checked the internal source code, Status object has a little bit diverged since so status_macros.h just won't work (and pull others dependencies...) but I can try to simulate a similar method.

Actually, it's barely the same than the GLOP custom method ->

or-tools/ortools/glop/status.h

Lines 69 to 74 in 4477092

	// Macro to simplify error propagation between function returning Status.
	#define GLOP_RETURN_IF_ERROR(function_call) \
	do { \
	const Status return_status = function_call; \
	if (!return_status.ok()) return return_status; \
	} while (false)

[Mizux]

For VLOG_EVERY_N_SEC need some time since OSS Glog know nothing about time management (there is abseil::time now need to check few things...)

[TornadoJo]

Okay, got it - tx!

Going to start compile test with Gurobi meanwhile for cc and dotnet....

• After adding "print-% : ; @echo $* = $($*)" to the makefile to get the variables straight -> worked flawless!