Remove sealed modifier from CpSolver and implement standard dispose pattern#4955
Merged
lperron merged 2 commits intogoogle:mainfrom Dec 17, 2025
Merged
Conversation
…olver The sealed modifier was unnecessarily breaking inheritance for users who need to extend CpSolver. The standard IDisposable pattern with protected virtual Dispose(bool) allows safe inheritance while maintaining proper resource cleanup. This change: - Removes the sealed modifier from CpSolver class - Implements the standard dispose pattern with protected virtual Dispose(bool) - Allows derived classes to override disposal behavior safely - Maintains backward compatibility for existing non-inheriting code
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
sealedmodifier added toCpSolverin commit f2e2e49 breaks existing code that inherits fromCpSolver. Thesealedkeyword was not necessary for implementingIDisposableand prevents legitimate inheritance scenarios.Solution
This PR:
sealedmodifier from theCpSolverclassprotected virtual Dispose(bool disposing)Benefits
CpSolverfor custom solver implementationsDispose(bool disposing)to add their own cleanup logicExample Usage
With this change, users can safely inherit from
CpSolver:Related to commit: f2e2e49