Skip to content

Amend #4961, bump Java 21.#4966

Merged
gchatelet merged 12 commits intomainfrom
amend_java21_upgrading
Dec 27, 2025
Merged

Amend #4961, bump Java 21.#4966
gchatelet merged 12 commits intomainfrom
amend_java21_upgrading

Conversation

@gchatelet
Copy link
Collaborator

No description provided.

@Mizux
Copy link
Collaborator

Mizux commented Dec 25, 2025

is there a reason to force the usage of temurin jdk instead of using the default jdk provides by ubunutu registry directly on linux and brew on macos (or the one in the runner directly) ?
also using the runner default env should improve interoperability and extend our test surface area for free...

ref:
https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md#java
https://github.com/actions/runner-images/blob/main/images/macos/macos-15-arm64-Readme.md#java

bonus: since already installed, you don't have to "pay" the setup time + disk usage (and we are already close to the 10Go runner limit)

@gchatelet gchatelet changed the title Amend #4961, add missing .in files. Amend #4961, bump Java 21. Dec 26, 2025
@gchatelet
Copy link
Collaborator Author

I ended up removing "Check Java" and only setting JAVA_HOME in GITHUB_ENV

Copy link
Collaborator

@Mizux Mizux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gchatelet gchatelet merged commit bdfadac into main Dec 27, 2025
18 of 22 checks passed
@gchatelet gchatelet deleted the amend_java21_upgrading branch December 27, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants