harfrust: Initial setup#15284
Conversation
|
LGTM. Thanks. |
|
cmyr is integrating a new project: |
|
Can we get a review on this please? Thanks. |
DavidKorczynski
left a comment
There was a problem hiding this comment.
Why do we have these git clone in the build.sh and not in the Dockerfile?
the |
This is all copied/adapted from the setup for fontations, a related project.
|
@DavidKorczynski I believe I've fixed the build issue here and this should be ready for review. The long-term vision is that this project will eventually replace HarfBuzz in chrome, so we'd like to see the land sooner rather than later. |
| @@ -1,4 +1,4 @@ | |||
| # Copyright 2026 Google LLC | |||
| # Copyright 2024 Google LLC | |||
There was a problem hiding this comment.
can you update this to 2026?
|
please adjust the copyright year and then this looks good once the CI is green |
This is all copied/adapted from the setup for fontations, a related project.
@behdad will be the point person.