Fix Issues #20, #40, and #45 by using the same escaping as Protobuf d…

[mikegunter]

…istribution

The Unicode escaping that the Protocol Buffer distribution supports is
not implemented for now.

Add tests.

[judah]

Include the other ascii escapes like '\a', '\b', etc. in our TextFormat output?

[mikegunter]

I followed the distribution, see https://github.com/google/protobuf/blob/master/src/google/protobuf/stubs/strutil.cc#L578, in not emitting those.

This inspired me to add a test for parsing them, though.

[judah]

Overall looks good!

[mikegunter]

See the contents of escapeMessage and escapeRendered.

-m

On Wed, Sep 14, 2016 at 9:34 PM, Judah Jacobson [email protected]
wrote:

@judah commented on this pull request.

In proto-lens-tests/tests/text_format_test.hs
#48 (review):

@@ -57,8 +65,40 @@ main = testMain
, testCase "Render multiple lines" $
"d: 1\nd: 2\nd: 3" @=?
showMessageWithLineLength 3 (def4 & d .~ [1, 2, 3])

• , readFrom

•     "Parse string with escape sequences"
  

•      -- '\o172' == '\x7a' == 'z'
  

•     (Just $ def2 & b .~ "\o1\o12\o123\x2\o172z3z3")
  

•     (Data.Text.Lazy.pack "b: \"\001\012\123\002\172\x7a3\1723\"")
  

• , testCase "Render string with escape sequences" $

•    escapeRendered @=? showMessageShort escapeMessage
  

• , readFrom "Parse rendered string with escape sequences"

•           (Just escapeMessage) (Data.Text.Lazy.pack escapeRendered)
  

• , testCase "Render bytes" $

•     invalidUTF8BytesRendered @=? showMessage invalidUTF8BytesMessage
  

• , readFrom "Parse single-quote-delimited string"

Can you add a test for an escape quote nested inside a string (assuming we
don't already have it)? For example, "abc"def"

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#48 (review),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQ9hHHHmVXSpqFvVzj1w-cY8-Q6iXtRsks5qqMrXgaJpZM4J8zbq
.