Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

update futures dependency to 0.3 #19

Merged
merged 2 commits into from
Jan 18, 2020
Merged

Conversation

aav
Copy link
Contributor

@aav aav commented Dec 29, 2019

update futures dependency to 0.3

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@aav
Copy link
Contributor Author

aav commented Dec 29, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@aav aav changed the title update tokio futures dependency to 0.3 update futures dependency to 0.3 Dec 29, 2019
Copy link
Contributor

@darconeous darconeous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm almost certain I'll accept this commit as-is, but I'd like a little clarification on one part, outlined below.

}

*opt_mut = Some(Delay::new(d));
delay = opt_mut.as_mut().unwrap();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesn't immediately look related to the futures update. Can you elaborate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm.. i was almost 100% sure, that Delay::reset has been removed from the API, at some point. I will check and if it is still there, obviously, this change does not make sense, and I will revert it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just pushed the commit, which reverses unneeded Delay re-creation. Although, some small change is still needed - Delay::reset chnaged it's signature.

@darconeous darconeous added api-breaking Pull request contains (or issue may require) an API-breaking change enhancement New feature or request P1 Priority 1 task labels Jan 7, 2020
@aav
Copy link
Contributor Author

aav commented Jan 13, 2020

compilation fails due to regression in 1.42-nightly :(

rust-lang/rust#67743

@darconeous
Copy link
Contributor

With this change we can build on stable now, right?

@darconeous darconeous merged commit f9ffc6c into google:master Jan 18, 2020
@aav
Copy link
Contributor Author

aav commented Jan 19, 2020

Yes, it builds on stable

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api-breaking Pull request contains (or issue may require) an API-breaking change enhancement New feature or request P1 Priority 1 task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants