-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm almost certain I'll accept this commit as-is, but I'd like a little clarification on one part, outlined below.
} | ||
|
||
*opt_mut = Some(Delay::new(d)); | ||
delay = opt_mut.as_mut().unwrap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change doesn't immediately look related to the futures update. Can you elaborate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm.. i was almost 100% sure, that Delay::reset has been removed from the API, at some point. I will check and if it is still there, obviously, this change does not make sense, and I will revert it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just pushed the commit, which reverses unneeded Delay re-creation. Although, some small change is still needed - Delay::reset chnaged it's signature.
compilation fails due to regression in 1.42-nightly :( |
With this change we can build on stable now, right? |
Yes, it builds on stable |
update futures dependency to 0.3