Repository navigation
decode BINSTRING/SHORT_BINSTRING in custom_genops_from_bytes - #53
Open
abdul-khaliq-khalid wants to merge 1 commit into
Open
abdul-khaliq-khalid wants to merge 1 commit into
abdul-khaliq-khalid wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
custom_genops_from_bytes and partition_pickle_chunks never decode BINSTRING (0x54) or SHORT_BINSTRING (0x55), so for pickles at or above MIN_SIZE_FOR_CHUNKING (which run through this byte-buffer path via shared memory) any string operand carried in those opcodes is skipped and the unhandled byte desyncs the stride parser. A 31MB pickle holding os.system as SHORT_BINUNICODE scores unsafe=3 while the same payload as SHORT_BINSTRING scores unsafe=0, even though the stream path _custom_genops and the real unpickler both read these opcodes and this path should too. I decoded both the same way as their BINUNICODE siblings (1-byte and 4-byte latin-1 strings) and taught the chunk partitioner to skip them so boundaries stay opcode-aligned.