Apply transpose rule to safetensor saver function #971
+35
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current safetensor saver blindly saves merged tensor with tranpose. The transposition should be applied based on the huggingface vs tunix model implementation. This PR applies the transposition based on transpose rule instead, makes the logic more robust. The existing test covers saving and loading the checkpoint back.
Reference
Colab Notebook
Checklist