Skip to content

Use non-nullable parameters for operator == #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 2, 2022

Conversation

natebosch
Copy link
Member

The null value will never be passed to the equals operator
implementation. Widening the type causes any other class which
implements this interface to also widen the type.

The null value will never be passed to the equals operator
implementation. Widening the type causes any other class which
implements this interface to also widen the type.
@natebosch natebosch requested a review from kevmoo June 2, 2022 23:32
@coveralls
Copy link

coveralls commented Jun 2, 2022

Coverage Status

Coverage remained the same at 49.489% when pulling 30455fd on non-null-equals-parameter into 1c72944 on master.

Copy link
Collaborator

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth adding a change on entry here. Are there other planned changes or should you just release now?

@natebosch
Copy link
Member Author

This isn't very user visible, but I can add a changelog.

I'm eagerly cleaning this up because I hope we can add a lint.

@natebosch
Copy link
Member Author

Are there other planned changes or should you just release now?

No other changes planned. It's not terribly important to publish IMO, but I can drop the -dev and we can publish after internal validation.

@natebosch natebosch merged commit cdcee48 into master Jun 2, 2022
@natebosch natebosch deleted the non-null-equals-parameter branch June 2, 2022 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants