Skip to content

Attempt to address #119 #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

S0AndS0
Copy link

@S0AndS0 S0AndS0 commented Oct 18, 2024

Note: I'm not yet savvy enough with the source to sort-out why
self.locals.get is returning None instead of an empty string.

But this seems to work well enough for me 🤷

> Note: I'm not yet savvy enough with the source to sort-out why
> `self.locals.get` is returning `None` instead of an empty string.
>
> But this seems to work well enough for me 🤷
Copy link

google-cla bot commented Oct 18, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@S0AndS0
Copy link
Author

S0AndS0 commented Oct 18, 2024

Once you've signed, follow the "New Contributors" link at the bottom of that page to update this check.

There is no "New Contributors" link at the bottom of that page to update this check to follow⁉

@dbarnett
Copy link
Contributor

There is no "New Contributors" link at the bottom of that page to update this check to follow⁉

Dunno about what links to what anymore, but I think if you just comment "I signed it" here it'll recheck.

@S0AndS0
Copy link
Author

S0AndS0 commented Oct 19, 2024

Dunno about what links to what anymore, but I think if you just comment "I signed it" here it'll recheck.

Thanks @dbarnett!

"I signed it"

Edit 2024-10-19

🤦 Oh the link to click be in the "Details" for the blockage. Now I think the hitch in this PR's giddy-up is "Review required" section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants