Closed as not planned
Description
#1586 gates impls of zerocopy traits for atomic types on target_has_atomic = "xxx"
, ensuring that we don't emit invalid impls. On its own, that PR is correct, but attempts to be minimal in order to make quick progress and to avoid lumping a large refactor into what would otherwise be a small PR.
Separately, we should follow up and clean up atomics support in general:
- Consider co-locating the definition of
unsafe_impl_transparent_wrapper_for_atomic!
(inutil
in #1586) with its uses (inimpls
in #1586). Note that we may also want to avoid doing that since reasoning about the soundness of the body of that macro requires understanding the semantics ofTransparentWrapper
, so having it next to the definition ofTransparentWrapper
might be good. - Consider indirecting via an
Atomic
trait as prototyped in Gate implementations for Atomic* types behind #[cfg(target_has_atomic)] and Rust 1.60 #1091 - Consider adopting any other ideas from #1091 which weren't already carved out into separate PRs (#1585 and #1585)
Metadata
Metadata
Assignees
Labels
No labels