feat!: allow firebase/php-jwt v6 #391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshaffer
changed the title
This was referenced Apr 4, 2022
|
Bump - would be great to get merged in to enable meeting security SLAs! |
Contributor
Author
|
@ahthomsen for the record, firebase PHP-JWT offers a fix for this in v5.5, which this library supports. |
dwsupplee
suggested changes
Apr 11, 2022
vishwarajanand
suggested changes
Apr 12, 2022
Co-authored-by: David Supplee <[email protected]>
Co-authored-by: David Supplee <[email protected]>
Contributor
Author
|
@dwsupplee @vishwarajanand comments addressed! PTAL! |
vishwarajanand
approved these changes
Apr 12, 2022
Contributor
vishwarajanand
left a comment
vishwarajanand
left a comment
There was a problem hiding this comment.
LGTM but please have @dwsupplee approve as well.
dwsupplee
approved these changes
Apr 13, 2022
Contributor
dwsupplee
left a comment
dwsupplee
left a comment
There was a problem hiding this comment.
Looks great! Thanks for the tests 👍
Contributor
Author
|
This has been released in v1.21.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see CVE-2021-46743 and GHSA-8xf4-w7qw-pjjw